Bugs

yarik

Posted: 9 years ago

#6270 Quote

Total Posts: 5

Hi
MegaMenu Plugin Load twice the page some time more

It happens in CategoryMenuTemplate.WithPictures.cshtml
line 27 and 71


<img class="lazy" alt="@item.CategoryModel.PictureModel.AlternateText" src="#"                            title="@item.CategoryModel.PictureModel.Title" data-original="@item.CategoryModel.PictureModel.ImageUrl"/></a>

src="#" can't be #

You can fix the issue by changing source to src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs%3D" or just add transparent pixel image by default

Thanks
Yarik

http://www.uteam.co.il

Deni

Posted: 9 years ago

#6275 Quote

Status: Moderator
Total Posts: 389

yarik wrote:

MegaMenu Plugin Load twice the page some time more

src="#" can't be #

Hello,

The MegaMenu plugin uses lazy loading for the images - that means we load all images in the MegaMenu with ajax. The MegaMenu loads only once on page call and when you hover it, the thumbs in it load.

You can see that img src="#" is valid html, by validating this code on http://validator.w3.org/ :

<!DOCTYPE html>
<html>
<head>
<title>Nop Motion Responsive Theme Demo Store</title> 
</head>
<body>
<img class="lazy" src="#" alt="image" />
</body>
</html>

Best Regards !

Best Regards,
Mladen Staykov
Nop-Templates.com

yarik

Posted: 9 years ago

#6283 Quote

Total Posts: 5

May be it's valid by http://validator.w3.org/ , but if you open a firebug with net tab or fiddler you will see that src="#" cause for extra requests to the same page
and as result page load is very slow
Take a look for a screen please
http://snag.gy/4gN6M.jpg

Yarik

Deni

Posted: 9 years ago

#6286 Quote

Status: Moderator
Total Posts: 389

yarik wrote:

May be it's valid by http://validator.w3.org/ , but if you open a firebug with net tab or fiddler you will see that src="#" cause for extra requests to the same page
and as result page load is very slow
Take a look for a screen please
http://snag.gy/4gN6M.jpg

Yarik

Hello,

Yes, you are almost right. We have two more requests, but because browsers make asynchronous requests for each element, these two requests do not slow so much. We will change the src to be some base64 transparent image.

Thanks you for reporting this !

Best Regards,
Mladen Staykov
Nop-Templates.com

yarik

Posted: 9 years ago

#6287 Quote

Total Posts: 5

Thanks
Yarik

fun123

Posted: 9 years ago

#8089 Quote

Total Posts: 19

Mega menu not showing on IE, using 3.30 version......

Boyko

Posted: 9 years ago

#8093 Quote

Status: Moderator
Total Posts: 1570

fun123 wrote:

Mega menu not showing on IE, using 3.30 version......

Hi fun123,

Could you please specify the version of IE i.e IE8, IE9 etc. where you have problems with the Mega Menu?What theme do you use? It would be best if you can provide a link to your web site, so that we can see what is wrong.

Regards,
Nop-Templates.com Team

david.hirst

Posted: 9 years ago

#8425 Quote

Total Posts: 16

Hi,

I'm using Mega Menu within the Lighthouse template bundle for nopcommerce v3.20. I think the following is happening, in which case I think it is a bug, and from what I can see (or not see) it may be inside the dll? :
In the Nop Mega Menu settings, under section "Category Menu Settings" there is the option "Display only top level categories, which are marked as Show on home page". However, the "Show on home page" option on a category is used to define things like whether to show this category if featured categories are used on the home page. I believe the plugin should be using the "Include in top menu" category option? This is what should define whether the category appears in the top menu and therefore mega menu? I'm guessing you are using the wrong logic and it is causing me a problem because I need to control which categories appear in the mega menu and what goes into the featured categories independently.
I also just took a quick look at Mega Menu as used in a nopcommerce v3.40 template and I cannot even see this setting! Please tell me I will be able to still use this functionality as the v3.20 site will need upgrading to v3.40 or more likely 3.50 soon ...

Deni

Posted: 9 years ago

#8439 Quote

Status: Moderator
Total Posts: 389

david.hirst wrote:

In the Nop Mega Menu settings, under section "Category Menu Settings" there is the option "Display only top level categories, which are marked as Show on home page". However, the "Show on home page" option on a category is used to define things like whether to show this category if featured categories are used on the home page. I believe the plugin should be using the "Include in top menu" category option? This is what should define whether the category appears in the top menu and therefore mega menu? I'm guessing you are using the wrong logic and it is causing me a problem because I need to control which categories appear in the mega menu and what goes into the featured categories independently.

Hi,

Yes, I think our logic was not the best in 3.20.

But since 3.30 on, we show categories in the Mega Menu, only if they have "Include in top menu" checked (because this is the purpose of this setting)...

david.hirst wrote:

I also just took a quick look at Mega Menu as used in a nopcommerce v3.40 template and I cannot even see this setting! Please tell me I will be able to still use this functionality as the v3.20 site will need upgrading to v3.40 or more likely 3.50 soon ...

And this is why you do not see the other setting - "Display only top level categories, which are marked as Show on home page" - because we already use the default setting in the NOP. So you do not lose functionality, but you have easier configuration of the categories.

Regards!

Best Regards,
Mladen Staykov
Nop-Templates.com

david.hirst

Posted: 9 years ago

#8441 Quote