- 67
The Head element does not close either, see screenshot
Bugs
- Moderator
- 172
Hello JRon.
As you can see on the demo, the <head> tag is closing properly.
If it doesn't close properly on your site, you have to check any modifications you have made and find out what's wrong.
As you can see on the demo, the <head> tag is closing properly.
If it doesn't close properly on your site, you have to check any modifications you have made and find out what's wrong.
Regards,
Hristo Gospodinov
Nop-Templates.com
Hristo Gospodinov
Nop-Templates.com
- 67
There is no </head>, </body> or </html> tag if you view the source on https://avenue1.nop-templates.com or https://avenue2.nop-templates.com in any desktop browser (by opening the page, right click-ing and select "View source").
After viewing the source on some of the demo sites for your themes I can see that Voyage, Pacific, Emporium and Uptown render correctly with the closing elements but Avenue, Venture, Pavilion, Prisma, Earth and Brooklyn do not.
[code]
<!DOCTYPE html><html lang=en dir=ltr class=html-home-page><head><title>Nop Avenue Theme</title><meta charset=UTF-8><meta name=description content=""><meta name=keywords content=""><meta name=generator content=nopCommerce><meta name=viewport content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=2.0"><link rel=preload as=font href=/Themes/Avenue/Content/fonts/avenue_font.woff crossorigin><link href="https://fonts.googleapis.com/css?family=Nunito+Sans:300,400,800&subset=latin-ext&display=swap" rel=stylesheet><link rel=stylesheet href="/css/Homepage.Head.styles.css?v=z0q_No_QecUc17k4En_2xXY-lSg"><link rel=stylesheet href=/Plugins/SevenSpikes.Nop.Plugins.RestrictAdminAreaPermissions/Styles/restrict.admin.area.permissions.css><body class=home-page-body><input name=__RequestVerificationToken type=hidden value=CfDJ8DciUC9IFhBBpeQAlnHPVvCSVc8LsdQ60JkxVeFi-DIRRvg7_dMrhOFeDnvBsaJeFqC6ij8tnjFIFpHluZsmHIgevWzvrVs9L0o75Irfl7c5mqtLamQ2aeczFD6T4KtDRlgLC8Vq6vDENI6sD6FXh4w><div class=header-storetheme><div class=strip-left><a href="https://www.nop-templates.com/" class=strip-logo target=_blank></a><div class="strip-selector desktop"><label>Browse themes</label> <select id=browse-other-themes name=browse-other-themes><option value="https://voyage.nop-templates.com/">Voyage<option value=https://accessories-pacific.nop-templates.com/themedemo/preview>Pacific<option selected value=https://avenue1.nop-templates.com/themedemo/preview>Avenue<option value=https://supermarket.nop-templates.com/themedemo/preview>Emporium<option value=https://venture1.nop-templates.com/themedemo/preview>Venture<option value=https://electronics-prisma.nop-templates.com/themedemo/preview>Prisma<option value=https://earth1.nop-templates.com/themedemo/preview>Element<option value=https://poppy1.nop-templates.com/themedemo/preview>Poppy<option value=https://minimal1.nop-templates.com>Minimal<option value=https://uptown1.nop-templates.com/themedemo/preview>Uptown<option value="https://pavilion.nop-templates.com/">Pavilion<option value=https://brooklyn1.nop-templates.com/themedemo/preview>Brooklyn<option value="https://urban1.nop-templates.com/">Urban<option value="https://native.nop-templates.com/">Native<option value="https://tiffany1.nop-templates.com/">Tiffany<option value="https://artfactory.nop-templates.com/">ArtFactory<option value="https://motion.nop-templates.com/">Motion<option value="https://allure.nop-templates.com/">Allure<option value="https://traction.nop-templates.com/">Traction<option value="https://nitro.nop-templates.com/">Nitro<option value="https://lavella.nop-templates.com/">Lavella<option value="https://smart.nop-templates.com/">Smart<option value="https://alfresco.nop-templates.com/">Alfresco<option value="https://lighthouse.nop-templates.com/">Lighthouse<option value="https://alicante.nop-templates.com/">Alicante</select><div class=strip-theme-selector><div class=selected-theme>Avenue</div><div class="theme-list-wrap simplebar"><ul class=theme-list><li class=theme-item data-url="https://voyage.nop-templates.com/" data-name=Voyage><div class=theme-item-picture><img class=theme-item-img data-src=/Plugins/SevenSpikes.Nop.Plugins.ThemeDemosStripMenu/Themes/Voyage/Content/img/theme-image.png alt=Voyage></div><span class=theme-name>Voyage</span><li class=theme-item data-url=https://accessories-pacific.nop-templates.com/themedemo/preview data-name=Pacific><div class=theme-item-picture><img class=theme-item-img data-src=/Plugins/SevenSpikes.Nop.Plugins.ThemeDemosS
After viewing the source on some of the demo sites for your themes I can see that Voyage, Pacific, Emporium and Uptown render correctly with the closing elements but Avenue, Venture, Pavilion, Prisma, Earth and Brooklyn do not.
[code]
<!DOCTYPE html><html lang=en dir=ltr class=html-home-page><head><title>Nop Avenue Theme</title><meta charset=UTF-8><meta name=description content=""><meta name=keywords content=""><meta name=generator content=nopCommerce><meta name=viewport content="width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=2.0"><link rel=preload as=font href=/Themes/Avenue/Content/fonts/avenue_font.woff crossorigin><link href="https://fonts.googleapis.com/css?family=Nunito+Sans:300,400,800&subset=latin-ext&display=swap" rel=stylesheet><link rel=stylesheet href="/css/Homepage.Head.styles.css?v=z0q_No_QecUc17k4En_2xXY-lSg"><link rel=stylesheet href=/Plugins/SevenSpikes.Nop.Plugins.RestrictAdminAreaPermissions/Styles/restrict.admin.area.permissions.css><body class=home-page-body><input name=__RequestVerificationToken type=hidden value=CfDJ8DciUC9IFhBBpeQAlnHPVvCSVc8LsdQ60JkxVeFi-DIRRvg7_dMrhOFeDnvBsaJeFqC6ij8tnjFIFpHluZsmHIgevWzvrVs9L0o75Irfl7c5mqtLamQ2aeczFD6T4KtDRlgLC8Vq6vDENI6sD6FXh4w><div class=header-storetheme><div class=strip-left><a href="https://www.nop-templates.com/" class=strip-logo target=_blank></a><div class="strip-selector desktop"><label>Browse themes</label> <select id=browse-other-themes name=browse-other-themes><option value="https://voyage.nop-templates.com/">Voyage<option value=https://accessories-pacific.nop-templates.com/themedemo/preview>Pacific<option selected value=https://avenue1.nop-templates.com/themedemo/preview>Avenue<option value=https://supermarket.nop-templates.com/themedemo/preview>Emporium<option value=https://venture1.nop-templates.com/themedemo/preview>Venture<option value=https://electronics-prisma.nop-templates.com/themedemo/preview>Prisma<option value=https://earth1.nop-templates.com/themedemo/preview>Element<option value=https://poppy1.nop-templates.com/themedemo/preview>Poppy<option value=https://minimal1.nop-templates.com>Minimal<option value=https://uptown1.nop-templates.com/themedemo/preview>Uptown<option value="https://pavilion.nop-templates.com/">Pavilion<option value=https://brooklyn1.nop-templates.com/themedemo/preview>Brooklyn<option value="https://urban1.nop-templates.com/">Urban<option value="https://native.nop-templates.com/">Native<option value="https://tiffany1.nop-templates.com/">Tiffany<option value="https://artfactory.nop-templates.com/">ArtFactory<option value="https://motion.nop-templates.com/">Motion<option value="https://allure.nop-templates.com/">Allure<option value="https://traction.nop-templates.com/">Traction<option value="https://nitro.nop-templates.com/">Nitro<option value="https://lavella.nop-templates.com/">Lavella<option value="https://smart.nop-templates.com/">Smart<option value="https://alfresco.nop-templates.com/">Alfresco<option value="https://lighthouse.nop-templates.com/">Lighthouse<option value="https://alicante.nop-templates.com/">Alicante</select><div class=strip-theme-selector><div class=selected-theme>Avenue</div><div class="theme-list-wrap simplebar"><ul class=theme-list><li class=theme-item data-url="https://voyage.nop-templates.com/" data-name=Voyage><div class=theme-item-picture><img class=theme-item-img data-src=/Plugins/SevenSpikes.Nop.Plugins.ThemeDemosStripMenu/Themes/Voyage/Content/img/theme-image.png alt=Voyage></div><span class=theme-name>Voyage</span><li class=theme-item data-url=https://accessories-pacific.nop-templates.com/themedemo/preview data-name=Pacific><div class=theme-item-picture><img class=theme-item-img data-src=/Plugins/SevenSpikes.Nop.Plugins.ThemeDemosS
- 67
I tried to delete the code in the above post because it was cut off but got on error.
- 67
See here the difference in rendered source code from Voyager and Avenue demo sites.
- Moderator
- 172
"There is no </head>, </body> or </html> tag if you view the source on https://avenue1.nop-templates.com or https://avenue2.nop-templates.com"
That's a false alert from the browser inspector due to source code minification - the html markup is minified on the Avenue demos.
I can't tell why nopCommerce minification behaves like that in browser inspectors but that has nothing to do with the theme, it's in the framework (nopCommerce) which we don't have control over. If you inspect the nopCommerce demo you will see exactly the same thing (unclosed html, head and body tags). In fact you will see the same on every nopCommerce-based website that has minification enabled. But anyway, with or without HTML minification, the <html> &<head> & <body> tags validate normally.
"Compare Avenue and Voyage demos"
You see a difference only because Avenue has HTML minification enabled, and Voyage has it disabled. If they both have it enabled you will see no difference, and if they both have it disabled you will see no difference either.
That's a false alert from the browser inspector due to source code minification - the html markup is minified on the Avenue demos.
I can't tell why nopCommerce minification behaves like that in browser inspectors but that has nothing to do with the theme, it's in the framework (nopCommerce) which we don't have control over. If you inspect the nopCommerce demo you will see exactly the same thing (unclosed html, head and body tags). In fact you will see the same on every nopCommerce-based website that has minification enabled. But anyway, with or without HTML minification, the <html> &<head> & <body> tags validate normally.
"Compare Avenue and Voyage demos"
You see a difference only because Avenue has HTML minification enabled, and Voyage has it disabled. If they both have it enabled you will see no difference, and if they both have it disabled you will see no difference either.
Regards,
Hristo Gospodinov
Nop-Templates.com
Hristo Gospodinov
Nop-Templates.com
- 67
OK, I don´t have any minification settings enabled for this site, are those settings at some other place?
- Moderator
- 172
That's the settings. It's the "HTML minification" we are talking about.
Don't forget that after you disable it and click "Save", you also have to restart the application from the admin, otherwise the change will not apply.
Don't forget that after you disable it and click "Save", you also have to restart the application from the admin, otherwise the change will not apply.
Regards,
Hristo Gospodinov
Nop-Templates.com
Hristo Gospodinov
Nop-Templates.com
- 1
I have checked my nopCommerce (version 4.5) store, which uses Nop Templates theme Avenue, with Silktide Accessibility Checker and I found some issues related to Ajax Filter plugin.
I have an issue on category page where I use Ajax Filters plugin. When I check category page with Silktide Accessibility Checker then it shows an issue Screen reader links WCAG 2.0 A 4.1.2, which is related to clearFilterOptionsAll (<a class="clearFilterOptionsAll" title="Kustuta kõik" style="display: none;"></a>)
– „This link cannot be selected by a screen reader (there is no text content inside the link, or a href)“.
What is possible to do to make this link accessible for screen reader?
I have also another issue related to the same Ajax Filters plugin. When I try to navigate with keyboard on category page, then I can navigate to filter options only when filter is open. When fiter is closed, then filter is skipped and I can not navigate on filter options. Is this plugin using nonstandard keystrokes or these filters are not keyboard navigable?
I have an issue on category page where I use Ajax Filters plugin. When I check category page with Silktide Accessibility Checker then it shows an issue Screen reader links WCAG 2.0 A 4.1.2, which is related to clearFilterOptionsAll (<a class="clearFilterOptionsAll" title="Kustuta kõik" style="display: none;"></a>)
– „This link cannot be selected by a screen reader (there is no text content inside the link, or a href)“.
What is possible to do to make this link accessible for screen reader?
I have also another issue related to the same Ajax Filters plugin. When I try to navigate with keyboard on category page, then I can navigate to filter options only when filter is open. When fiter is closed, then filter is skipped and I can not navigate on filter options. Is this plugin using nonstandard keystrokes or these filters are not keyboard navigable?
