Close

Profile: petemitch

Avatar

User posts

Fixed in the latest update, thanks for the quick turnaround.

Regards, Pete.

I've applied the update and that's fixed it.  Thanks for the quick turnaround.

Regards, Pete.

Thanks, I'll keep an eye out for it.

Regards, Pete

iliyan.tanev wrote:
Can you suggest this to our UserVoice portal ?

tbh this isn't affecting my site any more since I'm using the Scroll To Element On The Page After Filtration option. I just thought you'd like to know since it affects your demo sites. I'm happy to use your UserVoice portal for enhancement suggestions but I regard this as a bug.

Regards, Pete.

As per the title, the Nop Ajax Cart doesn't seem to use the shoppingcart.headerquantity resource when updating the quantity shown on the flyout cart in the header. Easiest way to replicate it is on your demo site:
1. Go to http://www.themes.native.nop-templates.com/mountaineering-gear (the cart quantity in the header should be 0 in a little circle with NO brackets)
2. Add the product to the cart
3. The quantity field on the cart now displays "(1)" instead of the expected "1".
4. Reloading the page changes it back to the expected value of "1" with no brackets

Regards, Pete.

Well maybe not a bug in the strict sense but it's a slightly disorienting user experience.  When AJAX filters is enabled but the option to Scroll To Element On The Page After Filtration (Desktop) is unticked, clicking on the category page numbers doesn't cause the page to scroll. This is best demonstrated by trying it on your demo site:
1. Go to: http://demos.nop-templates.com/electronics
2. Scroll all the way to the bottom of the page (but keeping the pagination control in view)
3. Click to go to page 2

The exact visual effect depends on the size of the browser window, but all I see is the page numbers disappear.  What's actually happening is the products area is refreshed via AJAX and the page numbers move up out of view.  I think the Scroll To This Element After Filtration setting should be applied to paging actions regardless of the setting for Scroll To Element On The Page After Filtration.

Regards, Pete.

Hello.
Some of our product ribbons aren't displaying.  After a bit of investigation of narrowed it down to the Ajax request to RetrieveProductRibbons being passed an empty array.  To reproduce, go to this page on your demo site:http://demos.nop-templates.com/apple-icam.  Open Chrome developer tools, click the Network tab and filter the request types by XHR and reload the page. You should see the RetrieveProductRibbons request getting redirected to the custom errors page.

This image shows the error as I see it when testing on localhost: http://imageshack.com/a/img538/5283/xPWZnB.png

I also get this error in the error log:

System.ArgumentNullException: Value cannot be null.
Parameter name: source
   at System.Linq.Enumerable.Distinct[TSource](IEnumerable`1 source)
   at SevenSpikes.Nop.Plugins.ProductRibbons.Controllers.ProductRibbonsController.RetrieveProductRibbons(Int32[] categoryPageIds, Int32 productPageId)
   at lambda_method(Closure , ControllerBase , Object[] )
   at System.Web.Mvc.ActionMethodDispatcher.Execute(ControllerBase controller, Object[] parameters)
   at System.Web.Mvc.ReflectedActionDescriptor.Execute(ControllerContext controllerContext, IDictionary`2 parameters)
   at System.Web.Mvc.ControllerActionInvoker.InvokeActionMethod(ControllerContext controllerContext, ActionDescriptor actionDescriptor, IDictionary`2 parameters)
   at System.Web.Mvc.Async.AsyncControllerActionInvoker.<BeginInvokeSynchronousActionMethod>b__39(IAsyncResult asyncResult, ActionInvocation innerInvokeState)
   ...

Regards, Pete.

8 years ago

Cool thanks. I ended up changing the submit function to this:

$(".search-box form").submit(function(e) {
    var selectedCategory = $("#instant-search-categories").val() || 0;
    var searchedTerm = $("#small-searchterms").val();
    var showAdvancedSearch = selectedCategory == 0 ? "false" : "true";
    if (searchedTerm && searchedTerm != "") {
        window.location.href = "@Url.RouteUrl("HomePage")" + "search?adv=" + showAdvancedSearch + "&cid=" + selectedCategory + "&q=" + encodeURIComponent(searchedTerm) + "&[email protected]&isc=true";
    }
    e.preventDefault();
});

Which gives me the behaviour I wanted where the advanced search will show on the results page only if the user has selected a specific category from the search category dropdown.  Any possibility of you guys adding this to the plugin so I don't have to merge it after future upgrades?

Thanks, Pete.

8 years ago

I've noticed that when Instant Search is enabled all searches get passed with the querystring adv=true which shows the advanced search options on the search results page:
http://demos.nop-templates.com/filterSearch?adv=true&cid=0&q=apple&sid=True&isc=true
Is this the intended behaviour and is there a way to switch it off? I'd prefer it not displayed by default as it takes up a lot of space.

Thanks, Pete.

Edit: I should have mentioned this happens even if I'm not using the Enable category search option.  It makes sense to have them displayed when using a category search but otherwise I'd prefer them to remain hidden.